Adding FreeBSD build support. #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LadySerenaKitty
commented
Feb 2, 2024
|
Requested changes made, should be ready for merge. |
TheMostDiligent
requested changes
Feb 5, 2024
|
Everything builds up to this point: |
Please update all 4 submodules to the latest versions. |
I did that, re-applied some of my changes, and then this happened: |
LadySerenaKitty
force-pushed
the
master
branch
from
7f7e8fa to
e58e6a3
Compare
LadySerenaKitty
force-pushed
the
master
branch
from
b3b08ec to
9f736a9
Compare
| @@ -190,7 +190,7 @@ elseif(PLATFORM_ANDROID) | |||
| target_link_libraries(Diligent-SampleBase PRIVATE GLESv3 PUBLIC native_app_glue) | |||
| elseif(PLATFORM_LINUX) | |||
| find_package(X11 REQUIRED) | |||
| target_link_libraries(Diligent-SampleBase PRIVATE XCBKeySyms ${OPENGL_LIBRARY} X11::X11) | |||
| target_link_libraries(Diligent-SampleBase PRIVATE XCBKeySyms ${OPENGL_LIBRARY} ${X11_LIBRARIES}) | |||
| elseif(PLATFORM_MACOS OR PLATFORM_IOS) | |||
There was a problem hiding this comment.
Just wondering, why X11::X11 does not work - this is supposed to be the official way to link with X11 using CMake.
There was a problem hiding this comment.
I have no idea why it doesn't work, I just know it doesn't.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making all changes required to build on FreeBSD. Unity is not available for FreeBSD, so all Unity tests are disabled for FreeBSD. Some CMake entries for Linux may have changed, but their functionality remains unchanged.